Re: [PATCH v4] PM: domains: create debugfs nodes when adding power domains

From: Greg Kroah-Hartman
Date: Tue Dec 08 2020 - 15:40:01 EST


On Tue, Dec 08, 2020 at 11:19:55AM -0800, Thierry Strudel wrote:
> debugfs nodes were created in genpd_debug_init alled in late_initcall
> preventing power domains registered though loadable modules to have
> a debugfs entry.
>
> Create/remove debugfs nodes when the power domain is added/removed
> to/from the internal gpd_list.
>
> Signed-off-by: Thierry Strudel <tstrudel@xxxxxxxxxx>
> Change-Id: I8a2e0616746afe2a6bbd9c24bc3a0eaa84725a75

You don't need this, checkpatch.pl should have warned you :)

> ---
> v2: fix forward declaration and genpd_debugfs_dir being NULL - Ulf
> v3: remove extra trailing char added by mistake in v2 - kernel test robot
> v4: cleanup includes and regroup CONFIG_DEBUG_FS CPP blocks - Greg
> drivers/base/power/domain.c | 73 +++++++++++++++++++++++--------------
> 1 file changed, 45 insertions(+), 28 deletions(-)

Looks good to me, thanks for fixing it up. Rafael, will this go through
your tree?

Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>