Re: [PATCH] x86/platform: classmate-laptop: add WiFi media button

From: Hans de Goede
Date: Tue Dec 08 2020 - 05:20:21 EST


Hi,

On 12/8/20 7:11 AM, Chris Chiu wrote:
> From: Carlo Caione <carlo@xxxxxxxxxxxx>
>
> The WiFi media button on the Quanta NL3 reports keycodes 0x8b and 0x9b
> to the platform driver. Add the mapping to support these codes.
>
> Signed-off-by: Carlo Caione <carlo@xxxxxxxxxxxx>
> Reviewed-by: Chris Chiu <chiu@xxxxxxxxxxxxx>

Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans

> ---
> drivers/platform/x86/classmate-laptop.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/platform/x86/classmate-laptop.c b/drivers/platform/x86/classmate-laptop.c
> index af063f690846..3e03e8d3a07f 100644
> --- a/drivers/platform/x86/classmate-laptop.c
> +++ b/drivers/platform/x86/classmate-laptop.c
> @@ -1023,6 +1023,8 @@ static int cmpc_keys_codes[] = {
> KEY_CAMERA,
> KEY_BACK,
> KEY_FORWARD,
> + KEY_UNKNOWN,
> + KEY_WLAN, /* NL3: 0x8b (press), 0x9b (release) */
> KEY_MAX
> };
>
>