RE: [PATCH] platform/x86: dell-smbios-base: Fix error return code in dell_smbios_init

[Limonciello, Mario]

> 
> Hi,
> 
> +Cc Mario
> 
> On 11/25/20 7:50 AM, Qinglang Miao wrote:
> > Fix to return the error code -ENODEV when fails to init wmi and
> > smm.
> >
> > Fixes: 41e36f2f85af ("platform/x86: dell-smbios: Link all dell-smbios-*
> modules together")
> > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> > Signed-off-by: Qinglang Miao <miaoqinglang@xxxxxxxxxx>
> 
> Mario, this seems like a trivial fix to me, but I'm not 100% sure, any
> comments on this?
> 
> Regards,
> 
> Hans

Yeah, it's reasonable to me.

Reviewed-by: Mario Limonciello <mario.limonciello@xxxxxxxx>

> 
> 
> > ---
> >  drivers/platform/x86/dell-smbios-base.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/platform/x86/dell-smbios-base.c
> b/drivers/platform/x86/dell-smbios-base.c
> > index 2e2cd5659..3a1dbf199 100644
> > --- a/drivers/platform/x86/dell-smbios-base.c
> > +++ b/drivers/platform/x86/dell-smbios-base.c
> > @@ -594,6 +594,7 @@ static int __init dell_smbios_init(void)
> >  	if (wmi && smm) {
> >  		pr_err("No SMBIOS backends available (wmi: %d, smm: %d)\n",
> >  			wmi, smm);
> > +		ret = -ENODEV;
> >  		goto fail_create_group;
> >  	}
> >
> >