Re: [PATCH v2 3/6] PCI: brcmstb: Do not turn off regulators if EP can wake up

From: Florian Fainelli
Date: Mon Nov 30 2020 - 16:30:41 EST




On 11/30/2020 1:11 PM, Jim Quinlan wrote:
> If any downstream device may wake up during S2/S3 suspend, we do not want
> to turn off its power when suspending.
>
> Signed-off-by: Jim Quinlan <james.quinlan@xxxxxxxxxxxx>

Looks good to me, just one minor typo below:

> +enum {
> + TURN_OFF, /* Turn egulators off, unless an EP is wakeup-capable */

s/egulators/regulators/

> + TURN_OFF_ALWAYS, /* Turn Regulators off, no exceptions */
> + TURN_ON, /* Turn regulators on, unless pcie->ep_wakeup_capable */

--
Florian