Re: [PATCH] x86/e820: fix the function type for e820__mapped_all

From: Sami Tolvanen
Date: Mon Nov 30 2020 - 14:17:32 EST


On Fri, Nov 27, 2020 at 4:15 AM Borislav Petkov <bp@xxxxxxxxx> wrote:
> I think the proper fix is to fix the typedef to:
>
> typedef bool (*check_reserved_t)(u64 start, u64 end, enum e820_type type);
>
> because
>
> * is_mmconf_reserved() is passing in E820_TYPE_RESERVED which is enum e820_type
>
> * is_acpi_reserved() is the other check_reserved_t function ptr and the last arg
> type there is unused so it can just as well be enum e820_type.

Sure, sounds good. I'll send out v3 to change the type argument to
enum e820_type.

Sami