Re: [PATCH v4 2/2] media: i2c: Add support for the OV5648 image sensor

[Sakari Ailus]

Hi Paul,

On Mon, Nov 30, 2020 at 02:48:04PM +0100, Paul Kocialkowski wrote:
> Hi Sakari,
> 
> On Mon 30 Nov 20, 11:28, Sakari Ailus wrote:
> > Hi Paul,
> > 
> > Thanks for the update. I have a few comments on the driver, too.
> 
> Thanks for the review!
> 
> [...]
> 
> > > +	ret = ov5648_write(sensor, OV5648_GAIN_BLUE_MAN_L_REG,
> > > +			   OV5648_GAIN_BLUE_MAN_L(blue_balance));
> > 
> > return ...
> > 
> > Same below (and above).
> 
> Well I don't think that makes any functional difference, right?
> My personal preference is to have explicit checks even at the end of functions
> for symetry and alignment with other blocks.
> 
> If it's okay, it'd like to keep it as-is. But if that's against kernel coding
> style guidelines, I won't argue more.

Please do change them.

It's useless code, repeated at the end of a number of functions in this
driver. I wouldn't mind otherwise, but people do take examples from
existing drivers so such patterns tend to repeat in other places.

-- 
Regards,

Sakari Ailus