Re: [PATCH] posix_acl.h: define missing ACL functions on non-posix-acl build

From: Sergey Senozhatsky
Date: Mon Nov 30 2020 - 08:29:04 EST


Hi,

On (20/11/30 14:09), Andreas Gruenbacher wrote:
>
> Sergey, what actual problem is your patch trying to solve? It sounds
> like this is either theoretical and pointless, or you're trying to
> build an external module that uses POSIX ACL functions that shouldn't
> be needed when CONFIG_FS_POSIX_ACL is disabled.

It's an external module, that OpenWRT folks build with !FS_POSIX_ACL.
It compiles just fine, but modprobe fails because there are several
exported ACL symbols that don't provide dummy definitions (which the
module in question didn't guard with ifdef-s).

> In the latter case, the external module will just end up including dead
> code, so the module should be fixed instead.

ifdef-s work. But since posix_acl.h already provides some dummy
definitions for exported symbols, I thought that that list can
be extended (become complete).

-ss