Re: [PATCH] scsi: qla2xxx: remove trailing semicolon in macro definition

From: Daniel Wagner
Date: Mon Nov 30 2020 - 04:34:48 EST


On Mon, Nov 30, 2020 at 01:29:19AM -0800, Maciej Żenczykowski wrote:
> On Mon, Nov 30, 2020 at 1:23 AM Daniel Wagner <dwagner@xxxxxxx> wrote:
> > > #define QLA_QPAIR_MARK_NOT_BUSY(__qpair) \
> > > - atomic_dec(&__qpair->ref_count); \
> > > + atomic_dec(&__qpair->ref_count) \
> >
> > Nitpick, please insert an additional tab after the remove so that the
> > backlashes align again.
> >
>
> Uhm, if there's no semicolon, then presumably it's the final line of the
> macro, and thus there should be no tabs and no backslash at the end of the
> line.

Right! Didn't realize it. The backslash should be removed.