Re: [PATCH v2 0/8] Venus stateful encoder compliance

From: Fritz Koenig
Date: Sun Nov 29 2020 - 14:19:56 EST


Since this patchset adds support for V4L2_ENC_CMD_STOP and
VENUS_ENC_STATE_ENCODING it should also add support for
VIDIOC_TRY_ENCODER_CMD so that those commands are discoverable. I've
made an attempt at that here:
https://www.spinics.net/lists/linux-media/msg182319.html

On Wed, Nov 11, 2020 at 6:38 AM Stanimir Varbanov
<stanimir.varbanov@xxxxxxxxxx> wrote:
>
> Hello,
>
> Here is v2 of the subject patchset.
>
> The patchset starts with few small preparation and fix patches, 1/8 to 5/8.
> 6/8 is redesigned Dikshita's patch and 7/8 add Reset encoder state handling.
> The last 8/8 just delete not needed helper function.
>
> The major changes are:
> * An attempt to reuse m2m helpers for drain and reset state in 6/8 and 7/8.
> * Use null encoder buffer to signal end-of-stream in 6/8.
>
> Comments are welcome!
>
> regards,
> Stan
>
> Dikshita Agarwal (1):
> venus: venc: add handling for VIDIOC_ENCODER_CMD
>
> Stanimir Varbanov (7):
> venus: hfi: Use correct state in unload resources
> venus: helpers: Add a new helper for buffer processing
> venus: hfi_cmds: Allow null buffer address on encoder input
> venus: helpers: Calculate properly compressed buffer size
> venus: pm_helpers: Check instance state when calculate instance
> frequency
> venus: venc: Handle reset encoder state
> venus: helpers: Delete unused stop streaming helper
>
> drivers/media/platform/qcom/venus/helpers.c | 65 ++---
> drivers/media/platform/qcom/venus/helpers.h | 2 +-
> drivers/media/platform/qcom/venus/hfi.c | 2 +-
> drivers/media/platform/qcom/venus/hfi.h | 1 -
> drivers/media/platform/qcom/venus/hfi_cmds.c | 2 +-
> .../media/platform/qcom/venus/pm_helpers.c | 3 +
> drivers/media/platform/qcom/venus/venc.c | 232 +++++++++++++++---
> 7 files changed, 226 insertions(+), 81 deletions(-)
>
> --
> 2.17.1
>