Re: [BISECTED REGRESSION] Broken USB/GPIO on OMAP1 OSK

[Aaro Koskinen]

Hi,

On Sun, Nov 29, 2020 at 01:51:54AM +0200, Aaro Koskinen wrote:
> I tried to upgrade my OMAP1 OSK board to v5.9, but the rootfs cannot
> be accessed anymore due to broken USB. It fails to probe with the
> following logs:
> 
> [    9.219940] ohci ohci: cannot find GPIO chip i2c-tps65010, deferring
> [    9.250366] ohci ohci: cannot find GPIO chip i2c-tps65010, deferring
> [    9.731445] ohci ohci: cannot find GPIO chip i2c-tps65010, deferring
> [   10.342102] ohci ohci: cannot find GPIO chip i2c-tps65010, deferring
> [   10.966430] ohci ohci: cannot find GPIO chip i2c-tps65010, deferring
> 
> Bisected to:
> 
> commit 15d157e874437e381643c37a10922388d6e55b29
> Author: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Date:   Mon Jul 20 15:55:24 2020 +0200
> 
>     usb: ohci-omap: Convert to use GPIO descriptors
> 
> I suspect one of the issues is the name "i2c-tps65010" vs "tps65010":
> 
> # cat /sys/devices/platform/omap_i2c.1/i2c-1/i2c-tps65010/gpio/gpiochip208/label
> tps65010
> 
> However changing that in the lookup table still doesn't help much; I got rid
> of the "deferring" message but the USB still doesn't work. So far the only
> workaround I have is to revert the whole commit.

GPIO numbering goes wrong... It's now trying to poke GPIO2.

Also gpiod_set_value_cansleep() probably should be used as tps65010
can sleep.

A.