Re: Lockdep warning on io_file_data_ref_zero() with 5.10-rc5

From: Nadav Amit
Date: Sat Nov 28 2020 - 19:22:36 EST


> On Nov 28, 2020, at 4:13 PM, Pavel Begunkov <asml.silence@xxxxxxxxx> wrote:
>
> On 28/11/2020 23:59, Nadav Amit wrote:
>> Hello Pavel,
>>
>> I got the following lockdep splat while rebasing my work on 5.10-rc5 on the
>> kernel (based on 5.10-rc5+).
>>
>> I did not actually confirm that the problem is triggered without my changes,
>> as my iouring workload requires some kernel changes (not iouring changes),
>> yet IMHO it seems pretty clear that this is a result of your commit
>> e297822b20e7f ("io_uring: order refnode recycling”), that acquires a lock in
>> io_file_data_ref_zero() inside a softirq context.
>
> Yeah, that's true. It was already reported by syzkaller and fixed by Jens, but
> queued for 5.11. Thanks for letting know anyway!
>
> https://lore.kernel.org/io-uring/948d2d3b-5f36-034d-28e6-7490343a5b59@xxxxxxxxx/T/#t

Thanks for the quick response and sorry for the noise. I should improve my
Googling abilities and check the iouring repository the next time.

Regards,
Nadav