Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver

[Alexandre Belloni]

Hi Russell,

On 28/11/2020 19:37:07+0000, Russell King - ARM Linux admin wrote:
> On Sat, Nov 28, 2020 at 08:06:16PM +0100, Andrew Lunn wrote:
> > > +static void sparx5_phylink_mac_config(struct phylink_config *config,
> > > +				      unsigned int mode,
> > > +				      const struct phylink_link_state *state)
> > > +{
> > > +	struct sparx5_port *port = netdev_priv(to_net_dev(config->dev));
> > > +	struct sparx5_port_config conf;
> > > +	int err = 0;
> > > +
> > > +	conf = port->conf;
> > > +	conf.autoneg = state->an_enabled;
> > > +	conf.pause = state->pause;
> > > +	conf.duplex = state->duplex;
> > > +	conf.power_down = false;
> > > +	conf.portmode = state->interface;
> > > +
> > > +	if (state->speed == SPEED_UNKNOWN) {
> > > +		/* When a SFP is plugged in we use capabilities to
> > > +		 * default to the highest supported speed
> > > +		 */
> > 
> > This looks suspicious.
> > 
> > Russell, please could you look through this?
> 
> Maybe if I was copied on the patch submission... I don't have the
> patches, and searching google for them is a faff, especially
> when
> 
> site:kernel.org 20201127133307.2969817-1-steen.hegelund@xxxxxxxxxxxxx
> 
> gives:
> 
>    Your search - site:kernel.org
>    20201127133307.2969817-1-steen.hegelund@xxxxxxxxxxxxx - did not
>    match any documents. Suggestions: Make sure that all words are
>    spelled correctly. Try different keywords. Try more general
>    keywords.
> 

http://lore.kernel.org/r/20201127133307.2969817-1-steen.hegelund@xxxxxxxxxxxxx
does the right redirect.


-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com