Re: [PATCH] MAINTAINERS add D: tag for subsystem commit prefix

From: Tom Rix
Date: Sat Nov 28 2020 - 13:01:51 EST



On 11/28/20 8:44 AM, Joe Perches wrote:
> On Sat, 2020-11-28 at 08:30 -0800, Tom Rix wrote:
>> On 11/28/20 8:00 AM, Joe Perches wrote:
>>> On Sat, 2020-11-28 at 07:36 -0800, Tom Rix wrote:
>>>> On 11/27/20 2:10 PM, Joe Perches wrote:
>>> []
>>>>> I think an exception mechanism would be better than a specific
>>>>> mechanism added to various entries.
>>>> Can you give an example of what you mean ?
>>> Inherit the parent prefix then add the basename(dirname) as a default.
>>>
>>> For instance, changes to any subsystem of drivers/staging starts as
>>> "staging: " and with "$basename(path): " appended.
>> Ah, this is quite a bit different.
>>
>> As far as I can tell there is no default.
> The idea is to avoid adding a D: entry to each subsystem section.
Yeah, having looked at 2000+ on my initial populating of D's, it was not great
>
>> MAINTAINERS would only have the exceptions, obviously needing drivers/foo to be 'foo:'
>>
>> Without the full prefix, the user would be need to use get_maintainer.pl to figure it out.
> True. Or some other script.

I am ok with another script, maybe get_subsystem.py

>
>> Are the ""'s in the D value necessary ?
> Maybe not. I did that for clarity with the space after colon.
> My recollection is some systems used "[subsystem]" separators
> and other use / without space and not colons, but I'm for
> whatever approriate changes that support standarization
>
> I think most developer/maintainers don't care one way or
> another about patch commit prefixes, but those that do care
> seem to care a lot.
>
>
Yes, i agree.

Tom