Re: [PATCH] eCryptfs: add a semicolon

From: Joe Perches
Date: Fri Nov 27 2020 - 13:11:28 EST


On Fri, 2020-11-27 at 08:05 -0800, trix@xxxxxxxxxx wrote:
> Function like macros should have a semicolon.
[]
> diff --git a/fs/ecryptfs/keystore.c b/fs/ecryptfs/keystore.c
[]
> @@ -1172,7 +1172,7 @@ decrypt_pki_encrypted_session_key(struct ecryptfs_auth_tok *auth_tok,
>   rc = ecryptfs_cipher_code_to_string(crypt_stat->cipher, cipher_code);
>   if (rc) {
>   ecryptfs_printk(KERN_ERR, "Cipher code [%d] is invalid\n",
> - cipher_code)
> + cipher_code);

As this is the only use that does not have a semicolon,
it'd be good to add the removal of the semicolon from
the #define at the same time.