Re: [PATCH] misc: altera-stapl: remove trailing semicolon in macro definition

[Greg KH]

On Fri, Nov 27, 2020 at 08:54:21AM -0800, trix@xxxxxxxxxx wrote:
> From: Tom Rix <trix@xxxxxxxxxx>
> 
> The macro use will already have a semicolon.
> 
> Signed-off-by: Tom Rix <trix@xxxxxxxxxx>
> ---
>  drivers/misc/altera-stapl/altera-jtag.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/altera-stapl/altera-jtag.c b/drivers/misc/altera-stapl/altera-jtag.c
> index 27e8e0c9e8cf..0238600107b0 100644
> --- a/drivers/misc/altera-stapl/altera-jtag.c
> +++ b/drivers/misc/altera-stapl/altera-jtag.c
> @@ -17,9 +17,9 @@
>  #include "altera-jtag.h"
>  
>  #define	alt_jtag_io(a, b, c)\
> -		astate->config->jtag_io(astate->config->dev, a, b, c);
> +		astate->config->jtag_io(astate->config->dev, a, b, c)
>  
> -#define	alt_malloc(a)	kzalloc(a, GFP_KERNEL);
> +#define	alt_malloc(a)	kzalloc(a, GFP_KERNEL)

Ick, really?  That macro should be removed entirely.  Can you redo this
as a 2 patch series, the first for the alt_jtag_io() change, and the
other to remove all users of alt_malloc()?

thanks,

greg k-h