Re: [PATCH v2 1/3] genirq/affinity: Add irq_update_affinity_desc()

From: John Garry
Date: Thu Nov 26 2020 - 11:52:50 EST


Hi Marc,


https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/log/?h=irq/hacks


ok, I'll have a look

I tried that and it doesn't look to work.

I find that for the its_msi_prepare() call, its_dev->shared does not get set, as MSI_ALLOC_FLAGS_SHARED_DEVICE is not set in info->flags.

If I understand the code correctly, MSI_ALLOC_FLAGS_SHARED_DEVICE is supposed to be set in info->flags in platform_msi_set_desc(), but this is called per-msi after its_msi_prepare(), so we don't the flags set at the right time. That's how it looks to me...

Cheers,
John