Re: [PATCH] crypto: qat - Use dma_set_mask_and_coherent to simplify code

From: Giovanni Cabiddu
Date: Thu Nov 26 2020 - 07:04:21 EST


Hi Christophe,

On Sat, Nov 21, 2020 at 07:13:59AM +0000, Christophe JAILLET wrote:
> 'pci_set_dma_mask()' + 'pci_set_consistent_dma_mask()' can be replaced by
> an equivalent 'dma_set_mask_and_coherent()' which is much less verbose.
>
> While at it, also remove some unless extra () in the 32 bits case.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---
> Instead of returning -EFAULT, we could also propagate the error returned
> by dma_set_mask_and_coherent()
I'm going to re-submit implementing the comment above and also including
qat_4xxx.

Regards,

--
Giovanni