RE: [PATCH] regmap: sdw: add required header files

From: Liao, Bard
Date: Thu Nov 26 2020 - 06:42:31 EST




> -----Original Message-----
> From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> Sent: Thursday, November 26, 2020 1:35 PM
> To: Bard Liao <yung-chuan.liao@xxxxxxxxxxxxxxx>
> Cc: alsa-devel@xxxxxxxxxxxxxxxx; vkoul@xxxxxxxxxx; vinod.koul@xxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; tiwai@xxxxxxx; broonie@xxxxxxxxxx;
> jank@xxxxxxxxxxx; srinivas.kandagatla@xxxxxxxxxx;
> rander.wang@xxxxxxxxxxxxxxx; ranjani.sridharan@xxxxxxxxxxxxxxx;
> hui.wang@xxxxxxxxxxxxx; pierre-louis.bossart@xxxxxxxxxxxxxxx; Kale, Sanyog
> R <sanyog.r.kale@xxxxxxxxx>; Liao, Bard <bard.liao@xxxxxxxxx>
> Subject: Re: [PATCH] regmap: sdw: add required header files
>
> On Wed, Nov 25, 2020 at 09:01:28PM +0800, Bard Liao wrote:
> > From: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
> >
> > Explicitly add header files used by regmap SoundWire support.
>
> What is failing to build without this?

I didn't see build errors. But, Documentation/process/submit-checklist.rst
says.
1) If you use a facility then #include the file that defines/declares
that facility. Don't depend on other header files pulling in ones
that you use.

>
> thanks,
>
> greg k-h