Re: [PATCH] ACPI: processor: Drop duplicate setting of shared_cpu_map

From: Rafael J. Wysocki
Date: Wed Nov 25 2020 - 10:47:41 EST


On Tue, Nov 24, 2020 at 1:00 AM Punit Agrawal <punitagrawal@xxxxxxxxx> wrote:
>
> 'shared_cpu_map', stored as part of the per-processor
> acpi_processor_performance structre, is used to store cpus that share
> a performance domain. By definition it contains the owning cpu.
>
> While building the 'shared_cpu_map' it is being set twice - once while
> initialising the performance domains and again when matching cpus
> belonging to the same domain.
>
> Drop the unnecessary initialisation.
>
> Signed-off-by: Punit Agrawal <punitagrawal@xxxxxxxxx>
> ---
> drivers/acpi/processor_perflib.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/acpi/processor_perflib.c b/drivers/acpi/processor_perflib.c
> index b04a68950ff1..b0d320f18163 100644
> --- a/drivers/acpi/processor_perflib.c
> +++ b/drivers/acpi/processor_perflib.c
> @@ -616,7 +616,6 @@ int acpi_processor_preregister_performance(
> continue;
>
> pr->performance = per_cpu_ptr(performance, i);
> - cpumask_set_cpu(i, pr->performance->shared_cpu_map);
> pdomain = &(pr->performance->domain_info);
> if (acpi_processor_get_psd(pr->handle, pdomain)) {
> retval = -EINVAL;
> --

Applied as 5.11 material, thanks!