Re: [PATCH 22/25] perf buildid-cache: Add support to add build ids from perf data

[Namhyung Kim]

On Wed, Nov 25, 2020 at 10:00 PM Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
>
> On Tue, Nov 24, 2020 at 8:06 AM Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
> > diff --git a/tools/perf/builtin-buildid-cache.c b/tools/perf/builtin-buildid-cache.c
> > index a25411926e48..0bfb54ee1e5e 100644
> > --- a/tools/perf/builtin-buildid-cache.c
> > +++ b/tools/perf/builtin-buildid-cache.c
> > @@ -29,6 +29,11 @@
> >  #include "util/probe-file.h"
> >  #include <linux/string.h>
> >  #include <linux/err.h>
> > +#include <linux/zalloc.h>
> > +#include <sys/stat.h>
> > +#ifdef HAVE_DEBUGINFOD_SUPPORT
> > +#include <elfutils/debuginfod.h>
> > +#endif
> >
> >  static int build_id_cache__kcore_buildid(const char *proc_dir, char *sbuildid)
> >  {
> > @@ -348,6 +353,205 @@ static int build_id_cache__show_all(void)
> >         return 0;
> >  }
> >
> > +#ifdef HAVE_DEBUGINFOD_SUPPORT
>
> I think this part belongs to the next patch...?
>
> Thanks,
> Namhyung

Oh, I've missed we already have the debuginfod support.

Thanks,
Namhyung