Re: [PATCH] microblaze: Remove noMMU code

[Michal Simek]

On 25. 11. 20 13:57, Arnd Bergmann wrote:
> On Wed, Nov 25, 2020 at 1:14 PM Michal Simek <michal.simek@xxxxxxxxxx> wrote:
>>
>> And second part. I know I removed that Kconfig macros for it but maybe
>> good to talk about what needs to change to support different page size
>> for systems with MMU.
> 
> I would recommend just leaving it hardwired to 4K. The benefits of larger
> pages are rather questionable, especially on systems without tons of
> RAM, and it's an endless source of problems.
> 
> The commit that added the option, ba9c4f88d747 ("microblaze: Allow
> PAGE_SIZE configuration"), was rather nebulous with "can improve
> performance on some workloads".
> 
> On PowerPC, the benefits of larger pages are mainly for the hashed
> page table code, which I don't think exists anywhere else.

Is there any standard benchmark to see if there is really any benefit?
Exchanging tbl is quite expensive operation that's why there could be
good improvement.

But not a problem to remove it for now and get it back when this is
properly tested.

Thanks,
Michal