答复: [PATCH -next] sched/topology: Mark some symbols with static keyword

From: Zouwei (Samuel)
Date: Tue Nov 24 2020 - 20:32:17 EST


Quentin,
Thanks for the review. I will send the v2 soon.

-----邮件原件-----
发件人: Quentin Perret [mailto:qperret@xxxxxxxxxx]
发送时间: 2020年11月24日 21:24
收件人: Zouwei (Samuel) <zou_wei@xxxxxxxxxx>
抄送: mingo@xxxxxxxxxx; peterz@xxxxxxxxxxxxx; juri.lelli@xxxxxxxxxx; vincent.guittot@xxxxxxxxxx; dietmar.eggemann@xxxxxxx; rostedt@xxxxxxxxxxx; bsegall@xxxxxxxxxx; mgorman@xxxxxxx; bristot@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
主题: Re: [PATCH -next] sched/topology: Mark some symbols with static keyword

On Tuesday 24 Nov 2020 at 19:52:11 (+0800), Zou Wei wrote:
> Fix the following sparse warnings:
>
> kernel/sched/topology.c:211:1: warning: symbol 'sched_energy_mutex' was not declared. Should it be static?
> kernel/sched/topology.c:212:6: warning: symbol 'sched_energy_update' was not declared. Should it be static?
>
> Signed-off-by: Zou Wei <zou_wei@xxxxxxxxxx>

I think this wants:

Fixes: 31f6a8c0a471 ("sched/topology,schedutil: Wrap sched domains rebuild")

But, with that:

Reviewed-by: Quentin Perret <qperret@xxxxxxxxxx>

Thanks,
Quentin