Re: [PATCH 1/3] irqchip: qcom-pdc: Fix phantom irq when changing between rising/falling

From: Doug Anderson
Date: Tue Nov 24 2020 - 12:46:19 EST


Hi,

On Tue, Nov 24, 2020 at 9:42 AM Maulik Shah <mkshah@xxxxxxxxxxxxxx> wrote:
>
> Hi Linus,
>
> + * When we change types the PDC can give a phantom interrupt.
> + * Clear it. Specifically the phantom shows up if a line is already
> + * high and we change to rising or if a line is already low and we
> + * change to falling but let's be consistent and clear it always.
> + *
>
> Can you please hold this change. I am checking with HW folks if above
> commented behaviour is expected/is valid case to set the irq type rising
> edge when the line is already high.
>
> Will keep posting update here.
>
> Thanks,
> Maulik

Thanks for the update. I'm still going to post a v2 because I think
patch #1 in the series should land and it seems nice to keep them
together. I'll add a note to the patch indicating your request to
wait for an ack before landing.

-Doug