Re: [PATCH v2] ceph: add ceph.caps vxattr

From: Jeff Layton
Date: Tue Nov 24 2020 - 08:09:37 EST


On Mon, 2020-11-23 at 17:38 +0000, Luis Henriques wrote:
> Add a new vxattr that allows userspace to list the caps for a specific
> directory or file.
>
> Signed-off-by: Luis Henriques <lhenriques@xxxxxxx>
> ---
> Hi!
>
> Here's a version that also shows the caps in hexadecimal format, as
> suggested by Jeff. IMO the parenthesis and the '0x' prefix help the
> readability, but they may make it a bit harder for scripts to parsing the
> output. I'm OK dropping those.
>
> Cheers,

Looks good, merged into "testing".

I did make a slight change to the format -- instead of putting the hex
value in parenthesis, I separated the two fields with a /, which I think
should make things easier for scripts to parse.

You should be able to do something like this to get at the hex value for
testing:

$ getfattr -n ceph.caps foo | cut -d / -f2

Let me know if you see issues with that and we can revisit the format.

Thanks!
--
Jeff Layton <jlayton@xxxxxxxxxx>