Re: [PATCH 2/2] xfs: remove the extra processing of zero size in xfs_idata_realloc()

From: Christoph Hellwig
Date: Tue Nov 24 2020 - 06:52:54 EST


On Tue, Nov 24, 2020 at 06:45:31PM +0800, Zhen Lei wrote:
> krealloc() does the free operation when the parameter new_size is 0, with
> ZERO_SIZE_PTR returned. Because all other places use NULL to check whether
> if_data is available or not, so covert it from ZERO_SIZE_PTR to NULL.

This new code looks much harder to read than the version it replaced.