Re: [kbuild-all] Re: sound/soc/intel/catpt/loader.c:654 catpt_first_boot_firmware() warn: consider using resource_size() here

[Rong Chen]

On 11/23/20 7:41 PM, Rojewski, Cezary wrote:
> On 2020-11-23 11:53 AM, Andy Shevchenko wrote:
> > On Sun, Nov 22, 2020 at 03:52:27AM +0800, kernel test robot wrote:
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > > head:   27bba9c532a8d21050b94224ffd310ad0058c353
> > > commit: 6cbfa11d2694b8a1e46d6834fb9705d5589e3ef1 ASoC: Intel: Select catpt and deprecate haswell
> > > date:   7 weeks ago
> > > config: x86_64-randconfig-m001-20201122 (attached as .config)
> > > compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
> > >
> > > If you fix the issue, kindly add following tag as appropriate
> > > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > >
> > > smatch warnings:
> > > sound/soc/intel/catpt/loader.c:654 catpt_first_boot_firmware() warn: consider using resource_size() here
> > ...
> >
> > > a9aa6fb3eb6c7e Cezary Rojewski 2020-09-29  652  	for (res = cdev->dram.child; res->sibling; res = res->sibling)
> > > a9aa6fb3eb6c7e Cezary Rojewski 2020-09-29  653  		;
> > > a9aa6fb3eb6c7e Cezary Rojewski 2020-09-29 @654  	__request_region(&cdev->dram, res->end + 1,
> >
> > This sounds like false positive. From where it gets the idea of resource_size()
> > for the *start* offset?!
> Indeed it is false positive. I've already explained this in:
>
> RE: [bug report] ASoC: Intel: catpt: Firmware loading and context restore
> https://www.spinics.net/lists/alsa-devel/msg117145.html

Hi all,

Thanks a lot, we'll ignore the warning next time.

Best Regards,
Rong Chen