Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

From: Huacai Chen
Date: Sun Nov 15 2020 - 01:45:48 EST


Hi, Roman,

On Sun, Nov 15, 2020 at 6:02 AM Roman Kiryanov <rkir@xxxxxxxxxx> wrote:
>
> Hi Hancai,
>
> do you know if CONFIG_GOLDFISH_AUDIO is required for MIPS? I sent a
> patch to retire it.
Not required for MIPS.

Huacai
>
> Regards,
> Roman.
>
> On Sat, Nov 14, 2020 at 12:06 AM 陈华才 <chenhc@xxxxxxxxxx> wrote:
> >
> > Hi, All,
> >
> > Goldfish RTC works well on MIPS, and QEMU RISC-V emulator use Goldfish as well, so I think we should keep it in kernel.
> >
> > Huacai
> >
> >
> > ------------------ Original ------------------
> > From: "Greg KH"<gregkh@xxxxxxxxxxxxxxxxxxx>;
> > Date: Sat, Nov 14, 2020 07:43 AM
> > To: "Roman Kiryanov"<rkir@xxxxxxxxxx>;
> > Cc: "chenhc"<chenhc@xxxxxxxxxx>; "Paul Walmsley"<paul.walmsley@xxxxxxxxxx>; "LKML"<linux-kernel@xxxxxxxxxxxxxxx>; "Lingfeng Yang"<lfy@xxxxxxxxxx>; "Rob Herring"<robh@xxxxxxxxxx>;
> > Subject: Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH
> >
> >
> >
> > On Fri, Nov 13, 2020 at 03:36:49PM -0800, Roman Kiryanov wrote:
> > > +Greg KH
> > >
> > > On Fri, Nov 13, 2020 at 2:02 PM Roman Kiryanov <rkir@xxxxxxxxxx> wrote:
> > > >
> > > > Hi Hancai,
> > > >
> > > > I see you added /arch/mips/boot/dts/loongson/loongson64v_4core_virtio.dts which
> > > > refers to goldfish-rtc in 39c1485c8baa47aa20caefc1ec0a3410fbad6c81.
> > > > We (Android Studio Emulator aka "goldfish") do not support MIPS anymore.
> > > > Do you know if goldfish-rtc still works and is assumed to be available?
> >
> > I've dropped this patch from my trees now, please feel free to resend
> > when you have an updated version.
> >
> > thanks,
> >
> > greg k-h