Re: [PATCH v4 16/16] mm/filemap: Return only head pages from find_get_entries

From: Christoph Hellwig
Date: Sat Nov 14 2020 - 05:23:38 EST


On Thu, Nov 12, 2020 at 09:26:41PM +0000, Matthew Wilcox (Oracle) wrote:
> All callers now expect head (and base) pages, and can handle multiple
> head pages in a single batch, so make find_get_entries() behave that way.
> Also take the opportunity to make it use the pagevec infrastructure
> instead of open-coding how pvecs behave. This has the side-effect of
> being able to append to a pagevec with existing contents, although we
> don't make use of that functionality anywhere yet.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>