Re: [PATCH 2/2] kernel-doc: Handle function typedefs without asterisks

From: Matthew Wilcox
Date: Fri Nov 13 2020 - 17:39:23 EST


On Fri, Nov 13, 2020 at 03:21:06PM -0700, Jonathan Corbet wrote:
> On Fri, 30 Oct 2020 15:47:13 +0100
> Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote:
>
> > From: Eduardo Habkost <ehabkost@xxxxxxxxxx>
> >
> > Example of typedef that was not parsed by kernel-doc:
> >
> > typedef void (ObjectUnparent)(Object *obj);
> >
> > Signed-off-by: Eduardo Habkost <ehabkost@xxxxxxxxxx>
> > Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
>
> So as you've undoubtedly noticed, reading those kernel-doc regexes is ... a
> wee bit on the painful side. Trying to compare two of them in a patch to
> figure out what you have done is even worse. I suspect we want these
> patches, but can you please supply a changelog that describes the change?

Better ... can we have a test suite for the regexes and make patches to
them include updates to the test suite? They have clearly passed the
point of human understanding ;-)