Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

From: Rob Herring
Date: Fri Nov 13 2020 - 16:18:28 EST


On Fri, Nov 13, 2020 at 3:13 PM Roman Kiryanov <rkir@xxxxxxxxxx> wrote:
>
> Hi Rob, thank you for looking into this.
>
> On Fri, Nov 13, 2020 at 1:07 PM Rob Herring <robh@xxxxxxxxxx> wrote:
> >
> > On Fri, Nov 13, 2020 at 12:52:33PM -0800, rkir@xxxxxxxxxx wrote:
> > > From: Roman Kiryanov <rkir@xxxxxxxxxx>
> > >
> > > The only user of RTC_DRV_GOLDFISH is
> > > the MIPS flavor of Android Studio Emulator
> > > (goldfish) which should be also retired.
> > >
> > > Signed-off-by: Roman Kiryanov <rkir@xxxxxxxxxx>
> > > ---
> > > arch/riscv/Kconfig.socs | 1 -
> > > drivers/rtc/Kconfig | 10 --
> > > drivers/rtc/Makefile | 1 -
> > > drivers/rtc/rtc-goldfish.c | 216 -------------------------------------
> > > 4 files changed, 228 deletions(-)
> > > delete mode 100644 drivers/rtc/rtc-goldfish.c
> >
> > What about the binding and MAINTAINERS?
>
> My bad, I will update those files too.

Though the binding is still used in arch/mips/generic/board-ranchu.c
and arch/mips/boot/dts/loongson/loongson64v_4core_virtio.dts. The
latter was just added recently, so maybe premature to remove things?

Rob