Re: [PATCH] x86/boot/compressed/64: Drop the now-unused finalize_identity_maps()

[Vitaly Kuznetsov]

Arvind Sankar <nivedita@xxxxxxxxxxxx> writes:

> On Fri, Nov 13, 2020 at 04:08:10PM +0100, Vitaly Kuznetsov wrote:
>> Since commit 8570978ea030 ("x86/boot/compressed/64: Don't pre-map memory in
>> KASLR code") finalize_identity_maps() has no users, drop it.
>> 
>> Signed-off-by: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>
>> ---
>>  arch/x86/boot/compressed/ident_map_64.c | 10 ----------
>>  1 file changed, 10 deletions(-)
>> 
>> diff --git a/arch/x86/boot/compressed/ident_map_64.c b/arch/x86/boot/compressed/ident_map_64.c
>> index a5e5db6ada3c..6bf20223dc0f 100644
>> --- a/arch/x86/boot/compressed/ident_map_64.c
>> +++ b/arch/x86/boot/compressed/ident_map_64.c
>> @@ -167,16 +167,6 @@ void initialize_identity_maps(void *rmode)
>>  	write_cr3(top_level_pgt);
>>  }
>>  
>> -/*
>> - * This switches the page tables to the new level4 that has been built
>> - * via calls to add_identity_map() above. If booted via startup_32(),
>> - * this is effectively a no-op.
>> - */
>> -void finalize_identity_maps(void)
>> -{
>> -	write_cr3(top_level_pgt);
>> -}
>> -
>>  static pte_t *split_large_pmd(struct x86_mapping_info *info,
>>  			      pmd_t *pmdp, unsigned long __address)
>>  {
>> -- 
>> 2.26.2
>> 
>
> I had sent this and another unused removal last month:
> https://lore.kernel.org/lkml/20201005151208.2212886-1-nivedita@xxxxxxxxxxxx/
>

Ah, no problem, let this serve as a gentle ping to the maintainers then)

-- 
Vitaly