Re: ERROR: modpost: "mac_pton" undefined!

From: Michael S. Tsirkin
Date: Fri Nov 13 2020 - 10:19:45 EST


On Fri, Nov 13, 2020 at 02:19:31PM +0100, Laurent Vivier wrote:
> On 13/11/2020 14:12, Andy Shevchenko wrote:
> > On Fri, Nov 13, 2020 at 2:42 PM Laurent Vivier <lvivier@xxxxxxxxxx> wrote:
> >
> > ...
> >
> >>> If you fix the issue, kindly add following tag as appropriate
> >>> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> >>>
> >>> All errors (new ones prefixed by >>, old ones prefixed by <<):
> >>>
> >>>>> ERROR: modpost: "mac_pton" [drivers/vdpa/vdpa_sim/vdpa_sim.ko] undefined!
> >>
> >> I think something like this might fix the problem.
> >
> > ...
> >
> >> + select NET
> >> default n
> >
> > You may also drop 'default n' :-)
> >
> > But what I want to say is that API is under NET_UTILS, I dunno if the
> > driver requires full NET to be selected. And IIRC NET_UTILS is
> > selected by NET.
>
> I think GENERIC_NET_UTILS might be enough.

Yes that is ok to select.
But really vdpa sim is a fake ethernet device, nothing
much is lost if it depends on NET too.

> The problem I have for the moment is to find or1k-linux-gcc for my Fedora 33...
>
> Thanks,
> Laurent