RE: [PATCH] brcmfmac: fix error return code in brcmf_cfg80211_connect()

[Chi-Hsien.Lin]

> Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in th>
>
> Fixes: 3b1e0a7bdfee ("brcmfmac: add support for SAE authentication offload")
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@xxxxxxxxxx>
Reviewed-by: Chi-hsien Lin <chi-hsien.lin@xxxxxxxxxxxx>

> ---
>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadc>
> index a2dbbb9..0ee421f 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> @@ -2137,7 +2137,8 @@ brcmf_cfg80211_connect(struct wiphy *wiphy, struct net_device *ndev,
>               BRCMF_WSEC_MAX_PSK_LEN);
>     else if (profile->use_fwsup == BRCMF_PROFILE_FWSUP_SAE) {
>       /* clean up user-space RSNE */
> -             if (brcmf_fil_iovar_data_set(ifp, "wpaie", NULL, 0)) {
> +             err = brcmf_fil_iovar_data_set(ifp, "wpaie", NULL, 0);
> +             if (err) {
>                       bphy_err(drvr, "failed to clean up user-space RSNE\n");
>                       goto done;
> }
> --
> 2.9.5