RE: [PATCH v3 10/15] dt-binding: dma: dw-axi-dmac: Add support for Intel KeemBay AxiDMA

[Sia, Jee Heng]

> -----Original Message-----
> From: Rob Herring <robh@xxxxxxxxxx>
> Sent: 12 November 2020 10:58 PM
> To: Sia, Jee Heng <jee.heng.sia@xxxxxxxxx>
> Cc: vkoul@xxxxxxxxxx; Eugeniy.Paltsev@xxxxxxxxxxxx;
> andriy.shevchenko@xxxxxxxxxxxxxxx; dmaengine@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v3 10/15] dt-binding: dma: dw-axi-dmac: Add support for
> Intel KeemBay AxiDMA
> 
> On Thu, Nov 12, 2020 at 04:49:48PM +0800, Sia Jee Heng wrote:
> > Add support for Intel KeemBay AxiDMA to the dw-axi-dmac Schemas DT
> > binding.
> >
> > Signed-off-by: Sia Jee Heng <jee.heng.sia@xxxxxxxxx>
> > ---
> >  .../bindings/dma/snps,dw-axi-dmac.yaml        | 25 +++++++++++++++++++
> >  1 file changed, 25 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> > b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> > index 481ef0dacf5f..18e9422095bb 100644
> > --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> > +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> > @@ -8,6 +8,7 @@ title: Synopsys DesignWare AXI DMA Controller
> >
> >  maintainers:
> >    - Eugeniy Paltsev <Eugeniy.Paltsev@xxxxxxxxxxxx
> > +  - Jee Heng Sia <jee.heng.sia@xxxxxxxxx>
> >
> >  description: |
> >   Synopsys DesignWare AXI DMA Controller DT Binding @@ -16,6 +17,7 @@
> > properties:
> >    compatible:
> >      enum:
> >        - snps,axi-dma-1.01a
> > +      - intel,kmb-axi-dma
> >
> >    reg:
> >      items:
> > @@ -24,6 +26,7 @@ properties:
> >    reg-names:
> >      items:
> >        - const: axidma_ctrl_regs
> > +      - const: axidma_apb_regs
> 
> You need 'minItems: 1' here or everyone has to have 2 entries.
> 
> Also, doesn't 'reg' need updating?
> 
> >
> >    interrupts:
> >      maxItems: 1
> > @@ -124,3 +127,25 @@ examples:
> >           snps,priority = <0 1 2 3>;
> >           snps,axi-max-burst-len = <16>;
> >       };
> > +
> > +  - |
> > +     #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +     #include <dt-bindings/interrupt-controller/irq.h>
> > +     /* example with intel,kmb-axi-dma */
> > +     #define KEEM_BAY_PSS_AXI_DMA
> > +     #define KEEM_BAY_PSS_APB_AXI_DMA
> > +     axi_dma: dma@28000000 {
> > +         compatible = "intel,kmb-axi-dma";
> > +         reg = <0x28000000 0x1000 0x20250000 0x24>;
> 
> reg = <0x28000000 0x1000>, <0x20250000 0x24>;
[>>] Thanks Rob for the invaluable comments. Will update the changes in v4.
> 
> > +         reg-names = "axidma_ctrl_regs", "axidma_apb_regs";
> > +         interrupts = <GIC_SPI 88 IRQ_TYPE_LEVEL_HIGH>;
> > +         clock-names = "core-clk", "cfgr-clk";
> > +         clocks = <&scmi_clk KEEM_BAY_PSS_AXI_DMA>, <&scmi_clk
> KEEM_BAY_PSS_APB_AXI_DMA>;
> > +         #dma-cells = <1>;
> > +         dma-channels = <8>;
> > +         snps,dma-masters = <1>;
> > +         snps,data-width = <4>;
> > +         snps,priority = <0 0 0 0 0 0 0 0>;
> > +         snps,block-size = <1024 1024 1024 1024 1024 1024 1024 1024>;
> > +         snps,axi-max-burst-len = <16>;
> > +     };
> > --
> > 2.18.0
> >