Re: [PATCH net v2] net: x25: Increase refcnt of "struct x25_neigh" in x25_rx_call_request

From: Jakub Kicinski
Date: Thu Nov 12 2020 - 21:02:57 EST


On Thu, 12 Nov 2020 02:35:06 -0800 Xie He wrote:
> The x25_disconnect function in x25_subr.c would decrease the refcount of
> "x25->neighbour" (struct x25_neigh) and reset this pointer to NULL.
>
> However, the x25_rx_call_request function in af_x25.c, which is called
> when we receive a connection request, does not increase the refcount when
> it assigns the pointer.
>
> Fix this issue by increasing the refcount of "struct x25_neigh" in
> x25_rx_call_request.
>
> This patch fixes frequent kernel crashes when using AF_X25 sockets.
>
> Fixes: 4becb7ee5b3d ("net/x25: Fix x25_neigh refcnt leak when x25 disconnect")
> Cc: Martin Schiller <ms@xxxxxxxxxx>
> Signed-off-by: Xie He <xie.he.0141@xxxxxxxxx>

Applied, thanks!