Re: [PATCH] reboot: sync documentation with current code

From: Matteo Croce
Date: Thu Nov 12 2020 - 20:51:26 EST


On Fri, Nov 13, 2020 at 2:07 AM Matteo Croce <mcroce@xxxxxxxxxxxxxxxxxxx> wrote:
>
> From: Matteo Croce <mcroce@xxxxxxxxxxxxx>
>
> The valid values accepted by /sys/kernel/reboot/type are a bit different
> that the ones used in the kernel command line.
>
> In /sys we supports 'cf9_force' and 'cf9_safe', while in the kernel command
> line 'pci' and 'q' are used.
>
> Document the right values in the sysfs documentation.
>
> Fixes: eab8da48579d ("reboot: allow to specify reboot mode via sysfs")
> Signed-off-by: Matteo Croce <mcroce@xxxxxxxxxxxxx>
> ---
> Documentation/ABI/testing/sysfs-kernel-reboot | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-kernel-reboot b/Documentation/ABI/testing/sysfs-kernel-reboot
> index 837330fb2511..fcc5d193c16c 100644
> --- a/Documentation/ABI/testing/sysfs-kernel-reboot
> +++ b/Documentation/ABI/testing/sysfs-kernel-reboot
> @@ -16,7 +16,8 @@ What: /sys/kernel/reboot/type
> Date: November 2020
> KernelVersion: 5.11
> Contact: Matteo Croce <mcroce@xxxxxxxxxxxxx>
> -Description: Reboot type. Valid values are: bios acpi kbd triple efi pci
> +Description: Reboot type. Valid values are:
> + bios acpi kbd triple efi cf9_force cf9_safe
>
> What: /sys/kernel/reboot/cpu
> Date: November 2020
> --
> 2.28.0
>

So, discard this one, I will rename 'cf9_force' to 'pci' instead.
Simpler, and coherent with the kernel cmdline.

--
per aspera ad upstream