Re: [PATCH net-next] net: Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO

From: Dave Hansen
Date: Thu Nov 12 2020 - 20:43:59 EST


On 11/12/20 4:24 PM, Jakub Kicinski wrote:
> On Wed, 11 Nov 2020 09:34:24 +0800 kernel test robot wrote:
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Good people of kernel test robot, could you please rephrase this to say
> that the tag is only appropriate if someone is sending a fix up/follow
> up patch?
>
> Folks keep adding those tags on the next revisions of the their patches
> which is quite misleading.

I think it's still fair for the lkp folks to get *some* credit for
reporting these bugs.  I mean, the stated reason[1] for it existing is:

The Reported-by tag gives credit to people who find bugs and
report them and it hopefully inspires them to help us again in
the future.

I do agree, though, that it's confusing *what* they reported, especially
if the patch in question is fixing something *else*. Rather than invent
a new tag, maybe a comment would suffice:

Reported-by: kernel test robot <lkp@xxxxxxxxx> # bug in earlier revision

1.
https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes