Re: [PATCH] mailbox: arm_mhuv2: Add driver

[Jassi Brar]

On Wed, Nov 11, 2020 at 12:02 AM Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
>
> On 27-10-20, 17:23, Viresh Kumar wrote:
> > This adds driver for the ARM MHUv2 (Message Handling Unit) mailbox
> > controller.
> >
> > This is based on the accepted DT bindings of the controller and supports
> > combination of all transport protocols, i.e. single-word, multi-word and
> > doorbell.
> >
> > Transmitting and receiving data through the mailbox framework in
> > multi-word mode is done through struct arm_mhuv2_mbox_msg. Rest of the
> > implementation details can be seen in the bindings document or in the
> > driver itself.
> >
> > Based on the initial work done by Morten Borup Petersen from ARM.
> >
> > Co-developed-by: Tushar Khandelwal <tushar.khandelwal@xxxxxxx>
> > Signed-off-by: Tushar Khandelwal <tushar.khandelwal@xxxxxxx>
> > Tested-by: Usama Arif <usama.arif@xxxxxxx>
> > Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> > ---
> > Bindings are already reviewed by Rob and are present here:
> >
> > http://lore.kernel.org/lkml/61ca14fc441f92c1e7994e5bebae5c49811a3050.1602563406.git.viresh.kumar@xxxxxxxxxx
>
> Jassi, Any inputs on this ?
>
Can we make 'single-word' as a special case of 'multi-word',  i.e,
effect single-word by specifying 1 sized multi-word.
And the names of structs and members could be lower case? It seems
very firmware style, or is it just me?

cheers.