Re: Re: [PATCH V4 net-bugfixs] net/ethernet: Update ret when ptp_clock is ERROR

From: Richard Cochran
Date: Thu Nov 12 2020 - 18:27:41 EST


On Thu, Nov 12, 2020 at 10:21:21PM +0100, Arnd Bergmann wrote:
> I agree that the 'imply' keyword in Kconfig is what made this a
> lot worse, and it would be best to replace that with normal
> dependencies.

IIRC, this all started with tinification and wanting dynamic posix
clocks to be optional at compile time.

I would like to simplify this whole mess:

- restore dynamic posix clocks to be always included

- make PHC always included when the MAC has that feature (by saying
"select" in the MAC Kconfig) -- I think this is what davem had
wanted back in the day ...

I'm not against tinification in principle, but I believe it is a lost
cause.

Thanks,
Richard