Re: [PATCH] lib: stackdepot: Add support to configure STACK_HASH_SIZE

From: Andrew Morton
Date: Thu Nov 12 2020 - 17:57:12 EST


On Thu, 12 Nov 2020 18:26:24 +0530 Vijayanand Jitta <vjitta@xxxxxxxxxxxxxx> wrote:

> >> 1. page_owner=off, stackdepot_stack_hash=0 -> no more wasted memory
> >> when we don't use page_owner
> >> 2. page_owner=on, stackdepot_stack_hash=8M -> reasonable hash size
> >> when we use page_owner.
> >>
> >>
> >
> > This idea looks fine to me. Andrew and others would like to hear your
> > comments as well on this before implementing.
> >
> > Thanks,
> > Vijay
> >
>
> Awaiting for comments from Andrew and others.

I don't actually understand the problem.

What is it about page-owner that causes stackdepot to consume
additional memory? As far as I can tell, sizeof(struct stack_record)
isn't affected by page-owner?