Re: [PATCH] nfp: Fix passing zero to 'PTR_ERR'

From: Simon Horman
Date: Thu Nov 12 2020 - 10:26:13 EST


On Thu, Nov 12, 2020 at 10:58:52PM +0800, YueHaibing wrote:
> nfp_cpp_from_nfp6000_pcie() returns ERR_PTR() and never returns
> NULL. The NULL test should be removed, also return correct err.
>
> Fixes: 63461a028f76 ("nfp: add the PF driver")
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>

Thanks, this does indeed seem to be the case.

Reviewed-by: Simon Horman <simon.horman@xxxxxxxxxxxxx>