Re: [RFC PATCH net-next 3/3] net: dsa: listen for SWITCHDEV_{FDB,DEL}_ADD_TO_DEVICE on foreign bridge neighbors

From: Vladimir Oltean
Date: Thu Nov 12 2020 - 08:49:16 EST


On Wed, Nov 11, 2020 at 03:14:26PM +0100, Alexandra Winter wrote:
> On 11.11.20 11:36, Vladimir Oltean wrote:
> > Hi Alexandra,
> >
> > On Wed, Nov 11, 2020 at 11:13:03AM +0100, Alexandra Winter wrote:
> >> On 08.11.20 18:23, Vladimir Oltean wrote:
> >>> On Sun, Nov 08, 2020 at 10:09:25PM +0800, DENG Qingfang wrote:
> >>>> Can it be turned off for switches that support SA learning from CPU?
> >>>
> >>> Is there a good reason I would add another property per switch and not
> >>> just do it unconditionally?
> >>>
> >> I have a similar concern for a future patch, where I want to turn on or off, whether the
> >> device driver listens to SWITCHDEV_{FDB,DEL}_ADD_TO_DEVICE for a certain interface.
> >> (Options will be: static MACs only, learning in the device or learning in bridge and notifications to device)
> >> What about 'bridge link set dev $netdev learning_sync on self' respectively the corresponding netlink message?
> >
> > My understanding is that "learning_sync" is for pushing learnt addresses
> > from device to bridge, not from bridge to device.
> >
> uh, sorry copy-paste error. I meant:
> 'bridge link set dev $netdev learning on self'

Even with "learning" instead of "learning_sync", I don't understand what
the "self" modifier would mean and how it would help, sorry.