Re: [PATCH net] cosa: Add missing kfree in error path of cosa_write

From: Jakub Kicinski
Date: Thu Nov 12 2020 - 00:34:36 EST


On Tue, 10 Nov 2020 17:38:09 +0100 Jan Kasprzak wrote:
> Wang Hai wrote:
> : If memory allocation for 'kbuf' succeed, cosa_write() doesn't have a
> : corresponding kfree() in exception handling. Thus add kfree() for this
> : function implementation.
>
> Acked-By: Jan "Yenya" Kasprzak <kas@xxxxxxxxxx>

Applied, thanks!

> That said, COSA is an ancient ISA bus device designed in late 1990s,
> I doubt anybody is still using it. I still do have one or two of these
> cards myself, but no computer with ISA bus to use them.

Maybe we can move it out to staging or just remove it?