Re: [PATCH net-next] net: stmmac: platform: use optional clk/reset get APIs

[Jakub Kicinski]

On Wed, 11 Nov 2020 10:10:33 +0800 Jisheng Zhang wrote:
> On Mon, 9 Nov 2020 11:57:13 -0800 Jakub Kicinski wrote:
> > On Mon, 9 Nov 2020 16:09:10 +0800 Jisheng Zhang wrote:  
> > > @@ -596,14 +595,10 @@ stmmac_probe_config_dt(struct platform_device *pdev, const char **mac)
> > >               dev_dbg(&pdev->dev, "PTP rate %d\n", plat->clk_ptp_rate);
> > >       }
> > >
> > > -     plat->stmmac_rst = devm_reset_control_get(&pdev->dev,
> > > -                                               STMMAC_RESOURCE_NAME);
> > > +     plat->stmmac_rst = devm_reset_control_get_optional(&pdev->dev, STMMAC_RESOURCE_NAME);    
> > 
> > This code was wrapped at 80 chars, please keep it wrapped.
> >   
> 
> I tried to keep wrapped, since s/devm_reset_control_get/devm_reset_control_get_optional,
> to match alignment at open parenthesis on the second line, the
> "STMMAC_RESOURCE_NAME" will exceed 80 chars. How to handle this situation?

Indeed, it's 81 chars. Still one character over 80 is easier to read
than when STMMAC_RESOURCE_NAME is wrapped half way through the name.