Re: [PATCH] gpiolib: devres: shrink devm_gpiochip_add_data_with_key()

From: Andy Shevchenko
Date: Wed Nov 11 2020 - 10:01:25 EST


On Tue, Nov 10, 2020 at 11:42 AM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
>
> From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
>
> If all we want to manage is a single pointer, there's no need to
> manually allocate and add a new devres. We can simply use
> devm_add_action_or_reset() and shrink the code by a good bit.

Yes, it is possible to convert all one-function-based devm_*()
wrappers to use this approach.

The problem is, it will call the release() function on error which is
new (and probably undesired) behaviour.
I suppose you meant devm_add_action() here.


--
With Best Regards,
Andy Shevchenko