Re: [PATCH v2 0/2] Add new controls for QP and layer bitrate

From: Hans Verkuil
Date: Wed Nov 11 2020 - 06:48:27 EST


On 24/09/2020 19:42, Nicolas Dufresne wrote:
> Le lundi 21 septembre 2020 à 18:33 +0530, Dikshita Agarwal a écrit :
>> This series adds frame specific min/max qp controls for hevc and layer
>> wise bitrate control for h264.
>
> Any chance you could append your driver changes with this set ? I don't
> think new APIs ever make it without a driver using it.

Indeed. I'll mark this as 'Changes Requested' in patchwork: I do need a
version that actually uses these new controls in a driver.

Regards,

Hans

>
>>
>> Chnage since v1:
>> corrected email.
>>
>> Dikshita Agarwal (2):
>> media: v4l2-ctrl: Add frame-specific min/max qp controls for hevc
>> media: v4l2-ctrl: Add layer wise bitrate controls for h264
>>
>> .../userspace-api/media/v4l/ext-ctrls-codec.rst | 74 +++++++++++++++++++++-
>> drivers/media/v4l2-core/v4l2-ctrls.c | 15 +++++
>> include/uapi/linux/v4l2-controls.h | 17 +++++
>> 3 files changed, 104 insertions(+), 2 deletions(-)
>>
>