Re: [PATCH 0/5] add KERN_LEVEL to printk

From: Thomas Zimmermann
Date: Wed Nov 11 2020 - 03:51:14 EST


Hi

Am 11.11.20 um 09:31 schrieb Bernard Zhao:
> Hi:
>
> When call printk, set the KERN_LEVEL is suggested by the community.
> This patch sereies add KERN_* level to printk which do not set
> this level.

I have no say on the msm driver, but IMHO a much better change would be
a conversion to drm_dbg(), drm_err(), etc.

Best regards
Thomas

>
> Bernard Zhao (5):
> adreno/a2xx_gpu.c: add KERN_LEVEL to printk
> adreno/a3xx_gpu.c: add KERN_LEVEL to printk
> adreno/a4xx_gpu.c: add KERN_LEVEL to printk
> adreno/a5xx_gpu.c: add KERN_LEVEL to printk
> adreno/adreno_gpu.c: add KERN_LEVEL to printk
>
> drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 4 ++--
> drivers/gpu/drm/msm/adreno/a3xx_gpu.c | 4 ++--
> drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 6 +++---
> drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 2 +-
> drivers/gpu/drm/msm/adreno/adreno_gpu.c | 12 ++++++------
> 5 files changed, 14 insertions(+), 14 deletions(-)
>

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer