Re: [PATCH v3] bpf: Fix unsigned 'datasec_id' compared with zero in check_pseudo_btf_id

From: Andrii Nakryiko
Date: Wed Nov 11 2020 - 00:13:39 EST


On Tue, Nov 10, 2020 at 9:03 PM <xiakaixu1987@xxxxxxxxx> wrote:
>
> From: Kaixu Xia <kaixuxia@xxxxxxxxxxx>
>
> The unsigned variable datasec_id is assigned a return value from the call
> to check_pseudo_btf_id(), which may return negative error code.
>
> Fixes coccicheck warning:
>
> ./kernel/bpf/verifier.c:9616:5-15: WARNING: Unsigned expression compared with zero: datasec_id > 0
>
> Reported-by: Tosk Robot <tencent_os_robot@xxxxxxxxxxx>
> Signed-off-by: Kaixu Xia <kaixuxia@xxxxxxxxxxx>
> ---

Looks good.

Acked-by: Andrii Nakryiko <andrii@xxxxxxxxxx>

[...]