Re: [PATCH V2 net-next 11/11] net: hns3: add debugfs support for interrupt coalesce

From: Jakub Kicinski
Date: Tue Nov 10 2020 - 20:29:02 EST


On Mon, 9 Nov 2020 11:22:39 +0800 Huazhong Tan wrote:
> Since user may need to check the current configuration of the
> interrupt coalesce, so add debugfs support for query this info,
> which includes DIM profile, coalesce configuration of both software
> and hardware.
>
> Signed-off-by: Huazhong Tan <tanhuazhong@xxxxxxxxxx>

Please create a file per vector so that users can just read it instead
of dumping the info into the logs.

Even better we should put as much of this information as possible into
the ethtool API. dim state is hardly hardware-specific.