Re: [PATCH 2/2] mm: simplify follow_pte{,pmd}

From: Matthew Wilcox
Date: Tue Nov 10 2020 - 13:42:24 EST


On Thu, Oct 29, 2020 at 11:14:32AM +0100, Christoph Hellwig wrote:
> Merge __follow_pte_pmd, follow_pte_pmd and follow_pte into a single
> follow_pte function and just pass two additional NULL arguments for
> the two previous follow_pte callers.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Reviewed-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>

I'm not entirely convinced this is the right interface, but your patch
makes things better, so I approve.